Stop using draw_pending from sync functions#35759
Closed
zmanuel wants to merge 1 commit intogodotengine:masterfrom
Closed
Stop using draw_pending from sync functions#35759zmanuel wants to merge 1 commit intogodotengine:masterfrom
zmanuel wants to merge 1 commit intogodotengine:masterfrom
Conversation
Keep it in the _draw functions. That way it still makes extra sure no two draw calls can be pending/executing at the same time, even though the command FIFO already takes care of that. Fixes godotengine#35718
Contributor
Author
|
Serves the same purpose as #35758, which I would prefer. Correctness depends on my understanding of what CommandQueueMT does. |
Member
|
Closing in favor of #35758 per the author's request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep it in the _draw functions. That way it still makes extra sure
no two draw calls can be pending/executing at the same time,
even though the command FIFO already takes care of that.
Fixes #35718