Export: Add dedicated --export-pack option to export data pack#34913
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jan 8, 2020
Merged
Export: Add dedicated --export-pack option to export data pack#34913akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
Member
Author
|
BTW I checked and currently the |
Member
|
This is a pretty good idea, it should make things more obvious 🙂 I documented both changes in the changelog. |
Calinou
approved these changes
Jan 8, 2020
The previous behavior relying on the provided extension was problematic on macOS since .zip is the main extension used for the full project export (binary + data pack). We add a dedicated `--export-pack` command line option to define when only the data pack should be exported. Its extension will still be inferred from the path. Fixes godotengine#23073.
cbe23d1 to
7c29ce4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous behavior relying on the provided extension was problematic
on macOS since .zip is the main extension used for the full project
export (binary + data pack).
We add a dedicated
--export-packcommand line option to define whenonly the data pack should be exported. Its extension will still be
inferred from the path.
Fixes #23073.
Slightly breaks compat again, as it's no longer possible to export a data pack with
--exportor--export-debug, users will now have to use--export-pack. I think it's not a big breakage though and easy to adapt to, if anyone was actively using this hidden misfeature in the first place.@Calinou Can you make sure to mention both this and the
s/custom_package/custom_template/changes in the changelog?