Make the performance reporting update frequency customizable#18998
Merged
mhilbrunner merged 1 commit intoMay 26, 2018
Merged
Conversation
The default update frequency has been changed from 1000ms to 250ms.
Member
|
Would have liked @reduz to review this one before merging, because |
Member
|
I reverted this, as this is not the right approach to solve the problem, and all it may cause is game stalls (which are happening already with the remote scene tree). We learned from the remote scene tree than a different way to send this information over from the debugger is needed, probably from a thread. This needs more research before any of this should be touched. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default update frequency has been changed from 1000ms to 250ms. This makes FPS counter and monitor updates smoother and more reactive. I couldn't notice any significant performance decreases by lowering the default reporting rate to 250ms, even on a nearly empty project which ran at over 4,000 FPS on my machine.
I had to redesign the FPS counting algorithm after this one so that FPS counting no longer relies on an update frequency of 1000ms.
This implements #2794.