Skip to content

Use correct shadow material in some cases in Mobile#111578

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
Kaleb-Reid:fix-shadow-cull-material
Oct 14, 2025
Merged

Use correct shadow material in some cases in Mobile#111578
Repiteo merged 1 commit into
godotengine:masterfrom
Kaleb-Reid:fix-shadow-cull-material

Conversation

@Kaleb-Reid

@Kaleb-Reid Kaleb-Reid commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

The clustered renderer uses a similar method, except the Mobile one was missing some checks. There are other checks missing that are in the clustered renderer, but I'm not sure if they are applicable or are missing for performance reasons.

Fixes #73827
Fixes #87644

@Kaleb-Reid Kaleb-Reid requested a review from a team as a code owner October 13, 2025 08:29
@AThousandShips AThousandShips added bug topic:rendering topic:3d cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Oct 13, 2025
@AThousandShips AThousandShips added this to the 4.6 milestone Oct 13, 2025
@Kaleb-Reid Kaleb-Reid force-pushed the fix-shadow-cull-material branch from ba7c9d5 to 8a8bd02 Compare October 14, 2025 20:44
@Kaleb-Reid Kaleb-Reid changed the title Use correct shadow material when changing cull mode in Mobile Use correct shadow material in some cases in Mobile Oct 14, 2025

@clayjohn clayjohn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@clayjohn clayjohn removed the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Oct 14, 2025
@Repiteo Repiteo merged commit 1e9d0ff into godotengine:master Oct 14, 2025
20 checks passed
@Repiteo

Repiteo commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

Thanks!

@Kaleb-Reid Kaleb-Reid deleted the fix-shadow-cull-material branch October 14, 2025 22:21
@akien-mga

Copy link
Copy Markdown
Member

Cherry-picked for 4.5.2.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shadow rendering does not respect cull mode on mobile renderer Vulkan Mobile: Point rendering casts solid shadows, as opposed to point shadows

5 participants