Always apply tonemapping to solid color background in Compatibility#111550
Open
Kaleb-Reid wants to merge 2 commits into
Open
Always apply tonemapping to solid color background in Compatibility#111550Kaleb-Reid wants to merge 2 commits into
Kaleb-Reid wants to merge 2 commits into
Conversation
c6f8fc9 to
7356c76
Compare
7356c76 to
6fcbccb
Compare
clayjohn
reviewed
Oct 22, 2025
fdabdd0 to
1a578bf
Compare
1a578bf to
e51dd3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sky shader always needs to be drawn if we are tonemapping.
If we are using a transparent background, tonemapping needs to happen in post because we are not drawing a sky shader.
Depends on #110911
Fixes #102860