Disable tonemapping for ReflectionProbes in Compatibility#111317
Disable tonemapping for ReflectionProbes in Compatibility#111317Kaleb-Reid wants to merge 1 commit into
Conversation
09b39b3 to
6c46eb4
Compare
aa7bfb0 to
a04871a
Compare
a04871a to
7fcad41
Compare
|
Although the existing behaviour is objectively a bug, I believe it is best not to cherry pick this sort of behaviour change because this bug is not critical, not a regression, and most importantly existing projects may have their visuals tweaked to look good with the existing behaviour. For these reasons, I’ve removed the cherry pick labels. |
blueskythlikesclouds
left a comment
There was a problem hiding this comment.
Would this cause color clipping in reflection probes? Or was that never ever a concern?
Ya, this will cause clipping since probes use RGB10A2 format. We probably need to be more clever here and use a reversible tonemapper for both reflection probes and sky, or just accept that clipping is going to happen |
Tonemapping should not be applied to ReflectionProbes, as that will cause it to be applied multiple times to the same values because tonemapping will happen again for the Viewport containing the probes.
Fixes #104429