Always use RenderSceneBuffers to manage backbuffer in Compatibility 3D#111240
Merged
Conversation
clayjohn
approved these changes
Oct 6, 2025
clayjohn
left a comment
Member
There was a problem hiding this comment.
Looks great to me!
Definitely seeing the code now this change makes a lot of sense. It is way safer and less complicated. So its a total win-win situation
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the suggested changes in #111229 (comment).
This is the only place where this function is used, and it causes headaches by sharing backbuffer states between 3D and 2D.
Should be merged after #111234 to avoid a persistent warning spam / broken backbuffer (depends on device?).
Fixes #97728