Add a segfault handler to dump the backtrace on Windows, Linux and OS X#11061
Conversation
|
This should probably default to on in SCons with an option to turn it off. Some of the issues I've fixed for people on IRC would've been so much faster if we didn't first have to teach them to use gdb. |
|
@hpvb Yeah, this will help reporting crashes for people that don't know gdb. Also I think it can be handy for random crashes too. |
81a032b to
93d577e
Compare
|
This looks great, one thing: Could you add documentation for --disable-backtrace to the --help documentation in main/main.cpp? |
8602b0c to
679bfb6
Compare
|
I've changed the --disable-backtrace to --disable-crash-handler and moved the crash handler code to its own .cpp/.h on each platform. |
|
Just some small clang-format errors now, and it seems that the iPhone platform won't build now. Maybe check to see if similar issues now exist for html5? |
4cbf3e2 to
83fe937
Compare
|
Rebased and fixed that iPhone platform compile error, should be good on html5 as well. |
Same as #10124 but for 3.0