GL: Set backbuffer texture filter for screen reading shaders#110335
Open
KeyboardDanni wants to merge 1 commit into
Open
GL: Set backbuffer texture filter for screen reading shaders#110335KeyboardDanni wants to merge 1 commit into
KeyboardDanni wants to merge 1 commit into
Conversation
736a5ff to
870698c
Compare
e1ca8b7 to
a65fd8d
Compare
a65fd8d to
bb86772
Compare
Contributor
Author
|
screentextureblur_modified.zip Here's my hastily modified version of the MRP used to test texture repeat, viewports, and 3D shaders. Use left and right arrow keys to switch between normal and viewport scenes. |
|
Thank you for taking the time to look into this KeyboardDanni. I'm hoping your work is merged in soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106787
This PR allows texture filter and repeat hints to work on the screen and depth textures in Compatibility mode. Tested in both 2D and 3D shaders.
The old version of this PR was keeping the screen reading textures in the
GeneratedCode's texture uniform list, but this led to multiple issues (wrong texture bindings, the screen texture slot appearing in the inspector). Now I'm just saving the screen texture filter to an enum stored in theGeneratedCodestruct, which rendering backends are free to use how they wish.Screen texture mipmaps seem to only work in the editor and not at runtime. As far as I'm aware this is an existing bug.
See the MRP for details.