Postpone adding new extension plugins to the editor#109310
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Aug 6, 2025
Merged
Conversation
dsnopek
reviewed
Aug 4, 2025
e7bcc5f to
d37b7f3
Compare
---- Extension EditorPlugins added during Hot Reload on Initialization level Editor were being attached to the scene tree before all the GDExtension Classes (such as already loaded resources) are re-initialized.
d37b7f3 to
1aca96d
Compare
dsnopek
approved these changes
Aug 5, 2025
Contributor
dsnopek
left a comment
There was a problem hiding this comment.
Thanks! This looks good to me :-)
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extension EditorPlugins added during Hot Reload on Initialization level Editor were being attached to the scene tree before all the GDExtension Classes (such as already loaded resources) are re-initialized.
In general, the order of the operations looked like so:
editor_add_plugin- which was instantly addingEditorPluginto the tree, launching its lifecycle methods.enter_tree()– we were still in hot reload and any GDExtension class instance at this point is represented by its base class – i.e. loading any previously initialized GDExtension Resource will return "bare" resource.Related godot-rust issue: godot-rust/gdext#1132
Thread on Godot contributors chat: https://chat.godotengine.org/channel/gdextension?msg=N2sbbbuw4Z33pacWF