Glow: Add pre additive blend mode#106995
Conversation
5911a03 to
08bbfbd
Compare
08bbfbd to
b8eedca
Compare
|
What do people think of calling this "Scene Additive" instead? "Pre" gives the user question as to what it is before. "Scene" may give hint that the glow is added to the scene, rather than the (post-tonemapped) image. This does assume that people can intuit a difference between the concept of a "scene" and post-tonemapping no longer being a "scene"... Really not sure if that's an improvement, but it's an idea I had that I figured I should share. I'd also be happy with "Pre Additive" as it currently is. |
Sounds good to me. |
|
If we want to change the Glow behavior, I would prefer to change the existing Additive mode to perform before tonemapping like this. Adding this extra mode doesn't seem very worthwhile in my opinion. |
Am I correct in understanding that the current "Additive" and this "Pre Additive" mode produce the same results when HDR 2D is enabled and when using the Linear tonemapper? If this is the case, then this would support this suggestion to replace the existing "Addtive" with the mode from this PR. |
|
Closing, see #106962 (comment) |
Close godotengine/godot-proposals#12528
Currently also integrates #106962This is independent of #106962.