Skip to content

Glow: Add pre additive blend mode#106995

Closed
beicause wants to merge 1 commit into
godotengine:masterfrom
beicause:glow-pre-additive-blend
Closed

Glow: Add pre additive blend mode#106995
beicause wants to merge 1 commit into
godotengine:masterfrom
beicause:glow-pre-additive-blend

Conversation

@beicause

@beicause beicause commented May 31, 2025

Copy link
Copy Markdown
Contributor

Close godotengine/godot-proposals#12528
Currently also integrates #106962 This is independent of #106962.

Comment thread scene/resources/environment.cpp Outdated
Comment thread doc/classes/Environment.xml Outdated
@beicause beicause force-pushed the glow-pre-additive-blend branch from 5911a03 to 08bbfbd Compare June 3, 2025 05:33
@beicause beicause force-pushed the glow-pre-additive-blend branch from 08bbfbd to b8eedca Compare June 3, 2025 10:09
@beicause beicause marked this pull request as ready for review June 3, 2025 10:18
@beicause beicause requested review from a team as code owners June 3, 2025 10:18
@allenwp

allenwp commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

What do people think of calling this "Scene Additive" instead?

"Pre" gives the user question as to what it is before. "Scene" may give hint that the glow is added to the scene, rather than the (post-tonemapped) image. This does assume that people can intuit a difference between the concept of a "scene" and post-tonemapping no longer being a "scene"...

Really not sure if that's an improvement, but it's an idea I had that I figured I should share. I'd also be happy with "Pre Additive" as it currently is.

@Calinou

Calinou commented Sep 4, 2025

Copy link
Copy Markdown
Member

What do people think of calling this "Scene Additive" instead?

Sounds good to me.

@beicause

beicause commented Sep 5, 2025

Copy link
Copy Markdown
Contributor Author

If we want to change the Glow behavior, I would prefer to change the existing Additive mode to perform before tonemapping like this. Adding this extra mode doesn't seem very worthwhile in my opinion.

@allenwp

allenwp commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

If we want to change the Glow behavior, I would prefer to change the existing Additive mode to perform before tonemapping like this. Adding this extra mode doesn't seem very worthwhile in my opinion.

Am I correct in understanding that the current "Additive" and this "Pre Additive" mode produce the same results when HDR 2D is enabled and when using the Linear tonemapper? If this is the case, then this would support this suggestion to replace the existing "Addtive" with the mode from this PR.

@beicause

Copy link
Copy Markdown
Contributor Author

Closing, see #106962 (comment)

@beicause beicause closed this Sep 10, 2025
@AThousandShips AThousandShips removed this from the 4.x milestone Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a glow blend mode that performs addition before tonemapping

4 participants