FTI - Add custom interpolation for wheels#105915
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Apr 30, 2025
Merged
Conversation
1be3e03 to
b665c9d
Compare
Member
Author
rburing
approved these changes
Apr 30, 2025
b665c9d to
a2b340a
Compare
Member
Author
|
Rebased as there is some problem today with CI with static checks. No change to code. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the 3D FTI has been moved to scene side, we have the opportunity to finally fix wheel interpolation to cope with high speed rotation.
Fixes #72207
Forward port of #105816
See #52846 (comment)
See #52846 (comment)
Description
Uses a somewhat "new" approach of managing the wheel interpolation from the vehicle rather than the wheels. This should be more efficient, and I don't think there should be any downsides. The vehicle is therefore set to the default
physics_interpolation_modeON and the wheels OFF, and the vehicle controls the wheels.Notes
m_rotationreaches high values.resetsand also vehicles first entering the tree on the frame, where transform must be reset after the first physics tick (which is the first place an xform is available).Discussion
This doesn't provide a general solution to the problem of phasing, it is specific to wheels. If we later do decide on a general solution, this solution can easily be replaced.