[3.x] FTI - Reduce VisualInstance xform notifications (reverted)#105681
Merged
lawnjelly merged 1 commit intogodotengine:3.xfrom Jun 13, 2025
Merged
[3.x] FTI - Reduce VisualInstance xform notifications (reverted)#105681lawnjelly merged 1 commit intogodotengine:3.xfrom
VisualInstance xform notifications (reverted)#105681lawnjelly merged 1 commit intogodotengine:3.xfrom
Conversation
This was referenced Apr 26, 2025
4b0eb7d to
5ec4fd3
Compare
akien-mga
approved these changes
Jun 12, 2025
Member
Author
|
Thanks! |
VisualInstance xform notificationsVisualInstance xform notifications (reverted)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spatialtransforms are already not sent to theVisualServerwhen physics interpolation is active, so there is actually no need for them to haveNOTIFICATION_TRANSFORM_CHANGEDcalled.This PR manages the
notify_transformstate while respecting calls toset_notify_transform()in derived classes.Notes
notify_transformstate from these when required.