Skip to content

[3.x] FTI - Reduce VisualInstance xform notifications (reverted)#105681

Merged
lawnjelly merged 1 commit intogodotengine:3.xfrom
lawnjelly:fti_reduce_xform_notifications
Jun 13, 2025
Merged

[3.x] FTI - Reduce VisualInstance xform notifications (reverted)#105681
lawnjelly merged 1 commit intogodotengine:3.xfrom
lawnjelly:fti_reduce_xform_notifications

Conversation

@lawnjelly
Copy link
Copy Markdown
Member

Spatial transforms are already not sent to the VisualServer when physics interpolation is active, so there is actually no need for them to have NOTIFICATION_TRANSFORM_CHANGED called.
This PR manages the notify_transform state while respecting calls to set_notify_transform() in derived classes.

Notes

  • Small optimization from [3.x] FTI - Fix 3D auto-resets #105463 I left for a separate PR because of the risk of regressions. So far it seems fine in testing.
  • Has to manage a separate request to be notified by derived classes, it does this by maintaining two state bools and calculating the actual notify_transform state from these when required.
  • Also applicable in 4.x.
  • I'm not absolutely sure how much real world performance will be gained here, but needless notifications are always good to remove.

@lawnjelly lawnjelly force-pushed the fti_reduce_xform_notifications branch from 4b0eb7d to 5ec4fd3 Compare May 30, 2025 06:15
@lawnjelly lawnjelly merged commit c416ace into godotengine:3.x Jun 13, 2025
14 checks passed
@lawnjelly
Copy link
Copy Markdown
Member Author

Thanks!

@lawnjelly lawnjelly deleted the fti_reduce_xform_notifications branch June 13, 2025 04:22
@lawnjelly lawnjelly changed the title [3.x] FTI - Reduce VisualInstance xform notifications [3.x] FTI - Reduce VisualInstance xform notifications (reverted) Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants