[macOS] Fix running with DisplayServerHeadless.#104660
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Mar 28, 2025
Merged
[macOS] Fix running with DisplayServerHeadless.#104660akien-mga merged 1 commit intogodotengine:masterfrom
DisplayServerHeadless.#104660akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
akien-mga
approved these changes
Mar 26, 2025
Member
Author
|
Replaced raw |
bruvzg
commented
Mar 27, 2025
|
|
||
| class DisplayServerMacOS : public DisplayServer { | ||
| // No need to register with GDCLASS, it's platform-specific and nothing is added. | ||
| GDCLASS(DisplayServerMacOS, DisplayServer); // Note: required for Object::cast_to. |
Member
Author
There was a problem hiding this comment.
Note: required for Object::cast_to.
This is currently false, but will be required after #103708
akien-mga
approved these changes
Mar 27, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression from #104397
Since macOS now using native run loop, this code can be executed even if
DisplayServerHeadlessis used andstatic_castwon't work.