Disable panic hooks in Release mode#889
Merged
Bromeon merged 1 commit intogodot-rust:masterfrom Sep 9, 2024
Merged
Conversation
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-889 |
Contributor
|
This partially addresses #845 (comment) so I like it But there is no way to enable |
Bromeon
reviewed
Sep 9, 2024
Member
Bromeon
left a comment
There was a problem hiding this comment.
Thank you!
Since the PR is not in draft: please squash the commits 🙂
510f3aa to
c1fcea0
Compare
Contributor
Author
|
Done. |
Ughuuu
commented
Sep 9, 2024
Member
|
Please add periods/fullstops at the end of comments. You can also change existing ones. |
c1fcea0 to
dfddbb4
Compare
Update private.rs Update private.rs Update private.rs Update private.rs Update Cargo.toml Update private.rs Update private.rs Update private.rs
dfddbb4 to
2db5ca4
Compare
Bromeon
approved these changes
Sep 9, 2024
Contributor
Author
|
Ok, look good from my side to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a flag that does extra logging only when enabled.
Edit: This improves performance a lot. From my tests, doing a project https://github.com/Ughuuu/performance-test where I call a function 1 million times, I get the following times before and after in godot-rust:
The function is a simple
noopfunction.