godot-bindings: dispatch on target OS instead of host OS (also supports Wasm)#1479
Merged
godot-bindings: dispatch on target OS instead of host OS (also supports Wasm)#1479
Conversation
4d19d78 to
f2287ce
Compare
…ts Wasm) Previously, gdextension-api internally selected the platform based on #[cfg(target_*)] directives. This always chose the host platform, since that dependency was used inside a build.rs script. Now, gdextension-api was updated to leave the choice to the caller for most flexibility (it could also check environment variables itself), which is the new code now added in godot-bindings.
f2287ce to
33e8b1e
Compare
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1479 |
Member
Author
|
Tested it with dodge-the-creeps and Wasm export (nothreads). It works without |
This was referenced Jan 11, 2026
This was referenced Jan 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
gdextension-apiinternally selected the platform based on#[cfg(target_*)]directives. This always chose the host platform, since that dependency was used inside a build.rs script. Now,gdextension-apiwas updated to leave the choice to the caller for most flexibility (it could also check environment variables itself), which is the new code now added in godot-bindings.As we now have a prebuilt Wasm artifact, it is now possible export to Wasm without
api-custom, and thus withoutbindgenand the entire LLVM toolchain.Relations: