Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: godbus/dbus
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.2.0
Choose a base ref
...
head repository: godbus/dbus
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.2.1
Choose a head ref
  • 17 commits
  • 19 files changed
  • 2 contributors

Commits on Dec 2, 2025

  1. ci: bump freebsd to 14.3

    This should fix the following error:
    
    > The resource 'projects/freebsd-org-cloud-dev/global/images/family/freebsd-14-2' was not found
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Dec 2, 2025
    Configuration menu
    Copy the full SHA
    9231ecb View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2025

  1. ci: use Go 1.25 on FreeBSD

    This is the latest supported Go version
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Dec 3, 2025
    Configuration menu
    Copy the full SHA
    7f5da1d View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2025

  1. Merge pull request #421 from kolyshkin/fix-freebsd

    ci: bump freebsd to 14.3
    guelfey authored Dec 19, 2025
    Configuration menu
    Copy the full SHA
    501de98 View commit details
    Browse the repository at this point in the history
  2. Revert "Use pointer semantics in depthCounter"

    This reverts commit 5942541.
    
    Pointer semantics on the caller are actually incorrect here: the
    returned depthCounter is passed on to a deeper validation function, but
    that shouldn't modify the original depthCounter from the caller. With
    pointer semantics, we don't count e.g. the depth of array nesting, but
    just how many arrays are present in the signature. For structs this is
    especially bad since EnterStruct is called for each struct field, so
    this unintentionally limited the number of struct fields that could be
    present in a signature to 32.
    
    Fixes #425.
    guelfey committed Dec 19, 2025
    Configuration menu
    Copy the full SHA
    7cdb65f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    81b5551 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #426 from godbus/fix/struct_member_32

    Allow more than 32 containers / struct fields in a signature
    guelfey authored Dec 19, 2025
    Configuration menu
    Copy the full SHA
    f5f1150 View commit details
    Browse the repository at this point in the history
  5. Remove go1.18 build tag

    It is no longer needed since commit 33c352a changed go to 1.20 in go.mod.
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin authored and guelfey committed Dec 19, 2025
    Configuration menu
    Copy the full SHA
    21130cc View commit details
    Browse the repository at this point in the history
  6. Remove old-style +build tags

    Those are no longer needed as the package requires Go >= 1.20
    since commit 33c352a.
    
    Generated by
    
    	go fix ./...
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin authored and guelfey committed Dec 19, 2025
    Configuration menu
    Copy the full SHA
    68031f9 View commit details
    Browse the repository at this point in the history
  7. Fix staticcheck ST1006 warnings

    Like this:
    
    > object_test.go:71:7: ST1006: receiver name should not be an underscore, omit the name if it is unused (staticcheck)
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin authored and guelfey committed Dec 19, 2025
    Configuration menu
    Copy the full SHA
    5245cc9 View commit details
    Browse the repository at this point in the history
  8. Use switch where it makes sense

    As recommended by staticcheck linter, e.g.
    
    > conn.go:448:3: QF1003: could use tagged switch on member (staticcheck)
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin authored and guelfey committed Dec 19, 2025
    Configuration menu
    Copy the full SHA
    d03c0be View commit details
    Browse the repository at this point in the history
  9. variant_parser: simplify switch statement

    As recommended by the staticcheck linter:
    
    > variant_parser.go:295:2: QF1002: could use tagged switch on sig.str (staticcheck)
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin authored and guelfey committed Dec 19, 2025
    Configuration menu
    Copy the full SHA
    1b92cdc View commit details
    Browse the repository at this point in the history
  10. Omit embedded fields

    As recommended by the staticcheck linter, e.g.
    
    > auth.go:60:14: QF1008: could remove embedded field "transport" from selector (staticcheck)
    kolyshkin authored and guelfey committed Dec 19, 2025
    Configuration menu
    Copy the full SHA
    135663e View commit details
    Browse the repository at this point in the history
  11. Ignore ST1008 warning for validSingle

    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin authored and guelfey committed Dec 19, 2025
    Configuration menu
    Copy the full SHA
    c5ff039 View commit details
    Browse the repository at this point in the history
  12. ci: bump golangci-lint to v2

    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin authored and guelfey committed Dec 19, 2025
    Configuration menu
    Copy the full SHA
    feb892a View commit details
    Browse the repository at this point in the history
  13. Merge pull request #419 from kolyshkin/golangci-v2

    Bump golangci-lint to v2, fix some issues found
    guelfey authored Dec 19, 2025
    Configuration menu
    Copy the full SHA
    88ce463 View commit details
    Browse the repository at this point in the history
  14. Fix and simplify getHomeDir

    Since commits 99fac80 and ec919d8 it's clear that getHomeDir is only
    used on Windows. Ironically, $HOME is not used on Windows (instead,
    it's %USERPROFILE%), so we always fallback to user.Current, which
    internally uses os.UserHomeDir to fill in HomeDir.
    
    So, let's just use os.UserHomeDir directly (and fall back to "/" in case
    of an error like the previous implementation did).
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin authored and guelfey committed Dec 19, 2025
    Configuration menu
    Copy the full SHA
    d3fc3b5 View commit details
    Browse the repository at this point in the history
  15. Merge pull request #422 from kolyshkin/homedir

    Fix and simplify getHomeDir
    guelfey authored Dec 19, 2025
    Configuration menu
    Copy the full SHA
    20d95a3 View commit details
    Browse the repository at this point in the history
Loading