Conversation
Gallery block toolbars were overlapping under the site header due to a missing class header, this provides a workaround.
olafleur
left a comment
There was a problem hiding this comment.
I was able to reproduce the fix. Good job! :)
AnthonyLedesma
left a comment
There was a problem hiding this comment.
Looks Good To Merge.
This issue was a bit strange in that the Toolbar component seems to have this missing class/style behavior when we are extending the existing toolbar on blocks with any custom controls.
This here is the spot in Gutenberg where the Toolbar is returned early without the 'components-accessible-toolbar' class.
https://github.com/WordPress/gutenberg/blob/7db6ba5cec54c64418600aa8f0e98088a0ba9cf4/packages/components/src/toolbar/index.js#L29-L42
Though the short-circuit is related to the toolbar label, this behavior exists when appending labels on all toolbars within CoBlocks.
|
The issue is fixed in the Gutenberg plugin as well - WordPress/gutenberg#32424. |
Description
Gallery block toolbars were overlapping under the site header due to a missing class, this provides a workaround by always applying that css rule to each block toolbar.
Additional findings:
Screenshots
Before:
After:
Types of changes
CSS rule update
How has this been tested?
Locally, in-editor
Checklist: