Skip to content

Fix Access Plan "Description" misbehavior when a classic block exists…#973

Merged
thomasplevy merged 1 commit intogocodebox:masterfrom
eri-trabiccolo:access-plans-tinymce
Oct 24, 2019
Merged

Fix Access Plan "Description" misbehavior when a classic block exists…#973
thomasplevy merged 1 commit intogocodebox:masterfrom
eri-trabiccolo:access-plans-tinymce

Conversation

@eri-trabiccolo
Copy link
Copy Markdown
Contributor

@eri-trabiccolo eri-trabiccolo commented Oct 22, 2019

… in a course/membership
fix #777

Description

See:
#777 (comment)

How has this been tested?

Manually, adding new plans, modifying and saving existing ones, reordering them:

  • with the Classic Editor plugin (so the old wp editor).
  • with the block editor and a Classic Editor block
  • with the block editor and the course page built with the Elementor editor (which basically is equal to say see the previous bullet)
  • with the block editor e no Classic Editor block

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding Standards.

@thomasplevy thomasplevy added the hacktoberfest PRs for this issue count towards Hacktoberfest contributions! label Oct 24, 2019
@thomasplevy thomasplevy merged commit ce377db into gocodebox:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest PRs for this issue count towards Hacktoberfest contributions!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Access Plan "Description" misbehaves when a "Classic" block exists on a course or membership

2 participants