Fix cs and docs#2351
Merged
Merged
Conversation
4d05a6e to
cd466c9
Compare
`LLMS_Admin_Notices_Core::clear_sidebar_notice()`
cd466c9 to
d2cf819
Compare
3464623 to
d9aa3dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small update mostly to fix some minor coding standard/doc standard issues (error and warnings - and while there fixing some old cs issues as well) about to be introduced in the pending release (#2321).
Most important though, look at the commit 4d05a6e.
We cannot really delete public methods on a minor version, even if it's highly unlikely anybody used them.
Also we want to deprecate them first, on a minor version, so that we can remove them on the next major version.
Also fixed some tests that broke after the recent codebase updates.
I reverted the changes to admin/views/dashboard.php as they are addressed in #2360 so to avoid conflicts.