Skip to content

Fix cs and docs#2351

Merged
ideadude merged 15 commits into
gocodebox:devfrom
eri-trabiccolo:fix-cs-docs
Mar 2, 2023
Merged

Fix cs and docs#2351
ideadude merged 15 commits into
gocodebox:devfrom
eri-trabiccolo:fix-cs-docs

Conversation

@eri-trabiccolo

@eri-trabiccolo eri-trabiccolo commented Feb 27, 2023

Copy link
Copy Markdown
Contributor

Small update mostly to fix some minor coding standard/doc standard issues (error and warnings - and while there fixing some old cs issues as well) about to be introduced in the pending release (#2321).

Most important though, look at the commit 4d05a6e.
We cannot really delete public methods on a minor version, even if it's highly unlikely anybody used them.
Also we want to deprecate them first, on a minor version, so that we can remove them on the next major version.

Also fixed some tests that broke after the recent codebase updates.

I reverted the changes to admin/views/dashboard.php as they are addressed in #2360 so to avoid conflicts.

@eri-trabiccolo eri-trabiccolo self-assigned this Feb 27, 2023
@eri-trabiccolo eri-trabiccolo changed the title Fix cs docs Fix cs and docs Feb 27, 2023
@eri-trabiccolo eri-trabiccolo requested a review from a team February 27, 2023 11:20
@eri-trabiccolo eri-trabiccolo added this to the 7.1 milestone Feb 28, 2023
@ideadude ideadude merged commit a83a810 into gocodebox:dev Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants