Skip to content

Improve some transactions query performance#2323

Merged
ideadude merged 3 commits into
gocodebox:devfrom
eri-trabiccolo:improve-some-transactions-query-perf
Feb 3, 2023
Merged

Improve some transactions query performance#2323
ideadude merged 3 commits into
gocodebox:devfrom
eri-trabiccolo:improve-some-transactions-query-perf

Conversation

@eri-trabiccolo

Copy link
Copy Markdown
Contributor

Description

Previously part of #2312

Some minor performance improvements by using the so called silver bullet no_found_rows when retrieving transactions without the need of pagination information, or total count.

How has this been tested?

manually and new tests

Types of changes

perfomance improvements

Checklist:

  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

@eri-trabiccolo eri-trabiccolo requested a review from a team January 12, 2023 11:49
@eri-trabiccolo eri-trabiccolo self-assigned this Jan 12, 2023
@eri-trabiccolo eri-trabiccolo force-pushed the improve-some-transactions-query-perf branch from 8bd5ca8 to cd49d01 Compare January 12, 2023 15:16
@ideadude ideadude merged commit c4d04d3 into gocodebox:dev Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants