Remove related access plans on course/membership deletion#1518
Merged
Conversation
also add updates routine to remove orphan access plans
Contributor
|
failing E2E tests are fixed when this branch is synced with dev |
thomasplevy
suggested changes
Feb 5, 2021
Co-authored-by: Thomas Patrick Levy <thomas@gocodebox.com>
89d1f2e to
8d5b513
Compare
3 tasks
This was referenced Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also add updates routine to remove orphan access plans
Description
per #263
How has this been tested?
only with new and old unit tests
haven't run a manual test though... I don't think we're going to merge this today, but if so, please run a manual test, I was running out of time :(
Types of changes
Bug fix (non-breaking change which fixes an issue)/New feature (non-breaking change which adds functionality)
Checklist: