@varshavaradarajan --
Wondering if the '+' is the best icon to indicate create pipeline within the group operation.

Few questions:

1. + icon shouldn't be confusing. What does it mean? Create a pipeline within the group? Or Create a new pipeline group itself?
2. Allowing to create new pipeline within a group, but not for environments. Will it be consistent?

\cc: @naveenbhaskar

+ icon shouldn't be confusing. What does it mean? Create a pipeline within the group? Or Create a new pipeline group itself?

If its specified along with the group name, it doesn't mean creating a new pipeline group, right?

Allowing to create new pipeline within a group, but not for environments. Will it be consistent?

Why are we aiming for consistency in this matter? Pipeline group and environment are 2 different entities. A pipeline must always belong to a pipeline group while a pipeline can be optionally part of some environment. Why is it not okay to display options that make sense for a pipeline group if it means improving the UX? If you think that doing this is not necessary, feel free to close the PR, though.

If you think that doing this is not necessary, feel free to close the PR, though.

@varshavaradarajan IMO, having an ability to create a pipeline on dashboard would be useful over going to a different page to do the same. We just need to decide on the right UX for this.

I always came up with this in my head, when I thought of the ability to add a pipeline to a group:

@arvindsv - should that add box be shown only for admins or be shown to everyone with the add button disabled for view users?

Also, are there plans to make a dashboard group expand/collapse? Because, having the add box in that case may not be of much use as it is still the same number of interactions as clicking on the group name from the dashboard and then clicking on "create a pipeline within this group" in /go/admin/pipelines?

@arvindsv - should that add box be shown only for admins or be shown to everyone with the add button disabled for view users?

I think it should show only for admins. /cc @naveenbhaskar Thoughts?

Also, are there plans to make a dashboard group expand/collapse? Because, having the add box in that case may not be of much use as it is still the same number of interactions as clicking on the group name from the dashboard and then clicking on "create a pipeline within this group" in /go/admin/pipelines?

True, but it's still an extra page load in that case. I think this box is still useful.

if we add a blank pipeline box at the end of pipeline group, the problems i see is

1. If there are a lot of pipelines in a group, user has to scroll a lot to reach the end and click on it.
2. There was a proposal for expand-collapse the pipeline groups, so this is not easily reachable.

The best place for adding a pipeline to the group is pipeline group header itself. it is easily accessible and noticeable and it should only show for people who can add pipelines.

This design will be consistent with design for admin-> pipelines

Would the possibility of combining @arvindsv @naveenbhaskar's designs be out of the question?

@arvindsv`s design would be really helpful/intuitive for new users, and @naveenbhaskar's design would add benefit for instances with a great number of pipelines.

thoughts?

+1 to what @ibnc said.

I like that suggestion, if it makes sense from a design perspective.

@naveenbhaskar - can you please review this PR when you're free? Thank you!

@arvindsv, @ibnc - by the way, just wanted to point out that a pipeline group which has no pipelines is not shown on the dashboard. So, this is only for making it easier to add pipelines to groups which already has at least one pipeline. Not sure if you want to change that as part of improving the ux for new users.

Hi all, I know I'm a little late to this issue but I do not think that having both buttons is a good design solution. I am anticipating that having the same action in two similar places will be confusing to a user, as I would expect each of those buttons to have an action different from one another.

My preference would be to have the button in the top of the pipeline group only, as it is the design that covers the use cases of having either a small number of pipelines OR a large number of pipelines.

+1 to @streisguth
Keeping 2 buttons to perform the same operation is confusing.

Can we do smart positioning?
If there are more than X pipelines (lets say 15), use the button at the top of the pipeline group.
And if there are less than X pipelines, use the '+' pipeline box?

Note:
Also, with this approach, the sudden change in the feature usability might cause confusion.

+1 to @streisguth .. There should not be two action element for the same action.

@naveenbhaskar - I've already made changes suggested by @streisguth . The New Pipeline button shows up in the dashboard group header like your screenshot. Do you mind reviewing the changes so we can get this merged?

sure @varshavaradarajan

@varshavaradarajan .. I have verified it and it is good to go from UI point of view.

The final UI screenshot:

\cc: @naveenbhaskar @varshavaradarajan @rajiesh @adityasood