SPAs - redirect to login page if unauthorized. (#4554)#4585
Conversation
|
Closing this as upon logging in, the url it goes to is |
|
This PR is still relevant. What needs fixing is the server side "remember url" logic. |
| }); | ||
| }; | ||
|
|
||
| const redirectToLoginPageIfUnauthorized = function(jqXHR) { |
There was a problem hiding this comment.
Since we're using $.ajax. We can probably add a global handler, if you like. http://api.jquery.com/category/ajax/global-ajax-event-handlers/.
|
Also — this might be relevant — |
6384d6f to
a5a909b
Compare
| } | ||
|
|
||
| private boolean isAnApiRequest(HttpServletRequest httpRequest) { | ||
| return httpRequest.getRequestURI().contains("/api/"); |
There was a problem hiding this comment.
I'd probably err on the side of doing a startsWith to avoid situations where you're accessing files/:pipeline_name/:pipeline_counter/:stage_name/:stage_counter/:job_name/foo/api/index.html
|
|
||
| /cctray.xml=modeAwareFilter,i18nlocaleResolver,httpSessionContextIntegrationFilter,apiSessionFilter,goLogoutFilter,removeAdminPermissionFilter,oauthProcessingFilter,basicProcessingFilter,authenticationProcessingFilter,reAuthenticationFilter,userEnabledCheckFilter,anonymousProcessingFilter,basicAuthenticationAccessDenied,denyGoCDAccessForArtifactsFilter,sessionFixationProtectionFilter,filterInvocationInterceptor,flashLoader,urlRewriter | ||
| /api/**=modeAwareFilter,i18nlocaleResolver,httpSessionContextIntegrationFilter,apiSessionFilter,goLogoutFilter,removeAdminPermissionFilter,oauthProcessingFilter,basicProcessingFilter,authenticationProcessingFilter,reAuthenticationFilter,userEnabledCheckFilter,anonymousProcessingFilter,basicAuthenticationAccessDenied,denyGoCDAccessForArtifactsFilter,sessionFixationProtectionFilter,filterInvocationInterceptor,flashLoader,urlRewriter | ||
| /api/**=modeAwareFilter,i18nlocaleResolver,httpSessionContextIntegrationFilter,apiSessionFilter,goLogoutFilter,removeAdminPermissionFilter,oauthProcessingFilter,basicProcessingFilter,authenticationProcessingFilter,reAuthenticationFilter,userEnabledCheckFilter,anonymousProcessingFilter,basicAuthenticationAccessDenied,cruiseLoginOrBasicAuthentication,denyGoCDAccessForArtifactsFilter,sessionFixationProtectionFilter,filterInvocationInterceptor,flashLoader,urlRewriter |
There was a problem hiding this comment.
What do you mean? I added cruiseLoginOrBasicAuthentication to api/**, didn't remove anything.
f41df56 to
055bff4
Compare
|
I tested the functionality locally. It works fine. |
* Set the status as 401 for an api request.
055bff4 to
eb15ae0
Compare
No description provided.