Conversation
|
@Mdevlin4 thanks for putting this together! To make the search box look and behave like how it is on the dashboard page we think it should look like this By default With a filter (notice the x button to cancel)
Tell us if you need help in getting it look like that. |
Removed search buttons and changed the filter to apply when the user types into the input box
…/madevl/labelfilter # Conflicts: # server/webapp/WEB-INF/rails.new/app/assets/javascripts/pipeline_history_search.js # server/webapp/WEB-INF/rails.new/app/assets/stylesheets/css/pipeline-history.scss # server/webapp/WEB-INF/vm/pipeline/pipeline_history.vm
|
Thanks for the feedback! I made those changes to make it look and function more like the search box on the dashboard page. Here is the default look: And the 'x' button to remove the filter: Thanks again for the suggestions! |
| PipelinePauseInfo pauseInfo = pipelinePauseService.pipelinePauseInfo(pipelineName); | ||
| boolean hasBuildCauseInBuffer = pipelineScheduleQueue.hasBuildCause(CaseInsensitiveString.str(pipelineConfig.name())); | ||
| PipelineInstanceModels pipelineHistory = pipelineHistoryService.load(pipelineName, pagination, username, true); | ||
| PipelineInstanceModels pipelineHistory = (labelFilter == null || labelFilter.trim().isEmpty()) ? |
There was a problem hiding this comment.
Sorry, missed this earlier.
We have a utility method https://github.com/gocd/gocd/blob/master/base/src/com/thoughtworks/go/util/StringUtil.java#L161 for checking blank strings can you use that here?
|
Thanks for the tip about the utility methods, I switched it to use the StringUtil class for the blank string check. |
Added an input box to the pipeline history view to filter pipelines by their label, comment, build cause, or revision.