feature: email notification for all stages of a pipeline.#229
feature: email notification for all stages of a pipeline.#229phoenix24 wants to merge 5 commits intogocd:masterfrom
Conversation
This reverts commit d4cb255.
… opening up multiple projects in idea.
|
I wonder if the label should be "[ANY STAGE]". To me, ALL implies that they all have to pass or fail to be notified. |
|
@kmugrage Yeah the label "[ANY STAGE]" sounds a better descriptor for the functionality. Please Let me know. |
|
@phoenix24 Let's wait a day or two to see if anyone responds. If not, I think you can make that change. |
|
+1 from me for "[ANY STAGE]". -- Ram On Thu, Jun 12, 2014 at 9:57 AM, Aravind SV notifications@github.com
Belenix: www.belenix.org |
|
add to the confusion: how about [EVERY STAGE] :) |
|
To me, every means that all 4 stages of a 4 stage pipeline would have to
|
|
@srinivasupadhya are you ok with [ANY STAGE] so this can be changed and merged? |
|
fine with it! :) |
|
Since this looks like it'll get merged soon, I thought I'd take a look at it. You've removed a call to hasSubscribedFor(). I think this will end up making every user (who has permission to see that pipeline) get a notification on failure (not checking whether they subscribed for that notification or not). The test that fails for this, is UserServiceIntegrationTest#shouldLoadUsersWhoSubscribedNotificationOnStage. Also, this pull request has commits from other pull requests too. Can you please fix that too? |
|
Closing this for now. Has seen no activity for more than a month. Can be fixed and reopened later, I suppose. |
This pull request allows users to add email notifications for all stages of any given pipeline.
At present one needs add notification or every stage of a given pipeline, this pull request eases this by allowing user to add a notification on all-stages of any pipeline.
It tries to do this by introducing a new label called [ALL STAGES], returning it as part of the stages list when viewed via MyController. We've also updated the test cases and found the feature changes to work as expected to when tested locally.
The choice for label "[ALL STAGES]" made sense to use, because its descriptive enough for the purpose and users are prohibited to create any pipelines or stages with starting with special characters.