Skip to content

Add URL endpoint to grab a snapshot of the config.git repository (#2188)#2240

Merged
zabil merged 1 commit intogocd:masterfrom
ketan:config-git-endpoint
Jun 13, 2016
Merged

Add URL endpoint to grab a snapshot of the config.git repository (#2188)#2240
zabil merged 1 commit intogocd:masterfrom
ketan:config-git-endpoint

Conversation

@ketan
Copy link
Member

@ketan ketan commented May 30, 2016

Git push has been explicitly disabled.

Usage -

$ git clone https://ci.example.com/go/api/config-repository[.git]

@zabil
Copy link
Contributor

zabil commented May 31, 2016

How's authentication handled?

@ketan
Copy link
Member Author

ketan commented May 31, 2016

@ketan
Copy link
Member Author

ketan commented May 31, 2016

How's authentication handled?
https://github.com/gocd/gocd/pull/2240/files#diff-10f894ef12c1ff6e9c8dac675693e03cR268

On second thought, there's a typo on that line, will wait for other comments.

@ketan ketan force-pushed the config-git-endpoint branch from 6f94b20 to 03603f3 Compare June 7, 2016 12:55
/api/admin/internal/pipelines=ROLE_SUPERVISOR,ROLE_GROUP_SUPERVISOR
/api/admin/**=ROLE_SUPERVISOR
/api/config-repository/**=ROLE_SUPERVISOR
/api/config-repository.git/**=ROLE_SUPERVISOR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we name the end point /admin/config.git we won't need this entry.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It conflicts with this rule

@zabil zabil added this to the Release 16.6 milestone Jun 13, 2016
@zabil zabil merged commit 206d324 into gocd:master Jun 13, 2016
@zabil zabil removed the in progress label Jun 13, 2016
@ketan ketan deleted the config-git-endpoint branch June 13, 2016 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants