Cannot save a job which has a colon (:) in its NAnt PATH #196
Description
Description
I noticed that you can't save a job which has a colon (:) in its NAnt PATH. The affected Go server version is 13.4.1(18342-b8df80323d8f89)
List of PATHs that gave me issue.
C:\Tools\nant-0.92\bin
C:\Tools\nant-0.92\bin\NAnt.exe
C:\Tools\nant-0.92
C:/Tools/nant-0.92/bin/NAnt.exe
C:/Tools/nant-0.92/bin
C:/Tools/nant-0.92
C:\Tools\nant-0.92\bin (escaped colon) works but fails when running the job. The error is that cmd.exe can't find the given path.
Try to save the job.
The page stalls. JavaScript console for Firebug reports a 500 response code. The Firebug console didn't have any interesting messages.
These are the log from Go server.
org/springframework/beans/SimpleTypeConverter.java:61:in `convertIfNecessary': org.springframework.beans.TypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'java.io.File'; nested exception is java.lang.IllegalArgumentException: name (NativeException)
from org/springframework/beans/SimpleTypeConverter.java:43:in `convertIfNecessary'
from com/thoughtworks/cruise/config/NantTask.java:53:in `setBuildTaskConfigAttributes'
from com/thoughtworks/cruise/config/BuildTask.java:53:in `setTaskConfigAttributes'
from com/thoughtworks/cruise/config/AbstractTask.java:144:in `setConfigAttributes'
from /home/jenkins/go-server/var/lib/go-server/work/Jetty_0_0_0_0_8153_cruise.war__go__.mt8b37/webapp/WEB-INF/rails/app/controllers/admin/tasks_controller.rb:95:in `update'
from /home/jenkins/go-server/var/lib/go-server/work/Jetty_0_0_0_0_8153_cruise.war__go__.mt8b37/webapp/WEB-INF/rails/app/controllers/admin_controller.rb:87:in `save'
from /home/jenkins/go-server/var/lib/go-server/work/Jetty_0_0_0_0_8153_cruise.war__go__.mt8b37/webapp/WEB-INF/rails/app/controllers/admin_controller.rb:14:in `save_popup'
from /home/jenkins/go-server/var/lib/go-server/work/Jetty_0_0_0_0_8153_cruise.war__go__.mt8b37/webapp/WEB-INF/rails/app/controllers/admin/tasks_controller.rb:85:in `update'
... 27 levels...
from file:/home/jenkins/go-server/var/lib/go-server/work/Jetty_0_0_0_0_8153_cruise.war__go__.mt8b37/webapp/WEB-INF/lib/jruby-rack-0.9.6-b6d3d45.jar!/jruby/rack/rails.rb:149:in `call'
from file:/home/jenkins/go-server/var/lib/go-server/work/Jetty_0_0_0_0_8153_cruise.war__go__.mt8b37/webapp/WEB-INF/lib/jruby-rack-0.9.6-b6d3d45.jar!/rack/handler/servlet.rb:19:in `call'
from :1
...internal jruby stack elided...
from org.springframework.beans.SimpleTypeConverter.convertIfNecessary(SimpleTypeConverter.java:43)
from com.thoughtworks.cruise.config.NantTask.setBuildTaskConfigAttributes(NantTask.java:53)
from com.thoughtworks.cruise.config.BuildTask.setTaskConfigAttributes(BuildTask.java:53)
from com.thoughtworks.cruise.config.AbstractTask.setConfigAttributes(AbstractTask.java:144)
2014-04-30 06:03:15,162 WARN [86466018@qtp-1589132288-17] log:76 - header full: java.lang.ArrayIndexOutOfBoundsException
2014-04-30 06:03:15,164 ERROR [86466018@qtp-1589132288-17] /go:87 - Error: Couldn't handle error: response committed
file:/home/jenkins/go-server/var/lib/go-server/work/Jetty_0_0_0_0_8153_cruise.war__go__.mt8b37/webapp/WEB-INF/lib/jruby-rack-0.9.6-b6d3d45.jar!/jruby/rack/response.rb:54:
in `write_body': java.lang.ArrayIndexOutOfBoundsException: null (NativeException)
from /home/jenkins/go-server/var/lib/go-server/work/Jetty_0_0_0_0_8153_cruise.war__go__.mt8b37/webapp/WEB-INF/rails/vendor/rails/actionpack/lib/action_controller/response.rb:155:in `each'
from file:/home/jenkins/go-server/var/lib/go-server/work/Jetty_0_0_0_0_8153_cruise.war__go__.mt8b37/webapp/WEB-INF/lib/jruby-rack-0.9.6-b6d3d45.jar!/jruby/rack/response.rb:74:in `write_body'
from file:/home/jenkins/go-server/var/lib/go-server/work/Jetty_0_0_0_0_8153_cruise.war__go__.mt8b37/webapp/WEB-INF/lib/jruby-rack-0.9.6-b6d3d45.jar!/jruby/rack/response.rb:37:in `respond'
from :1
...internal jruby stack elided...
The two errors that you see at the bottom of the screen are because Go server doesn't have git installed. They are unrelated to the current issue.