Removed the url from the not found page (#2584)

GaneshSPatil · zabil · commit faa6a2ae109e · 2016-08-24T18:00:06.000+05:30
* Removed the url from the not found page

* Changed the URL_NOT_FOUND error message
diff --git a/common/src/com/thoughtworks/go/i18n/LocalizedMessage.java b/common/src/com/thoughtworks/go/i18n/LocalizedMessage.java
@@ -92,8 +92,8 @@ public static Localizable X_of_Y(Object x, Object y) {
         return new LocalizedKeyValueMessage(LocalizedKeyValueMessage.X_OF_Y, x, y);
     }
 
-    public static Localizable urlNotKnown(String url) {
-        return new LocalizedKeyValueMessage(LocalizedKeyValueMessage.URL_NOT_KNOWN, url);
+    public static Localizable urlNotKnown() {
+        return new LocalizedKeyValueMessage(LocalizedKeyValueMessage.URL_NOT_KNOWN);
     }
 
     public static Localizable stageNotFound(StageIdentifier stageLocator) {
diff --git a/server/webapp/WEB-INF/rails.new/app/controllers/application_controller.rb b/server/webapp/WEB-INF/rails.new/app/controllers/application_controller.rb
@@ -98,7 +98,7 @@ def request_from_localhost?
   end
 
   def unresolved
-    render_error_response l.urlNotKnown(url_for), 404, false
+    render_error_response l.urlNotKnown, 404, false
   end
 
   def error_template_for_request
diff --git a/server/webapp/WEB-INF/rails.new/spec/controllers/application_controller_view_spec.rb b/server/webapp/WEB-INF/rails.new/spec/controllers/application_controller_view_spec.rb
@@ -135,7 +135,7 @@
     it "should render a pretty payload with message" do
       @controller.stub(:url_for).and_return("foo/bar")
       get :unresolved
-      expect(response.body).to have_selector("h3", :text=>"The url [ foo/bar ] you are trying to reach doesn't appear to be correct.")
+      expect(response.body).to have_selector("h3", :text=>"The url you are trying to reach appears to be incorrect.")
     end
 
     it "should render a 404" do
diff --git a/server/webapp/localize.xml b/server/webapp/localize.xml
@@ -119,7 +119,7 @@
     <entry key="FAILED_JOBS">Failed: {0}</entry>
     <entry key="IN_PROGRESS_JOBS">In Progress: {0}</entry>
     <entry key="UNABLE_TO_RETRIEVE_FAILURE_RESULTS">Unable to retrieve failure results.</entry>
-    <entry key="URL_NOT_KNOWN">The url [ {0} ] you are trying to reach doesn''t appear to be correct.</entry>
+    <entry key="URL_NOT_KNOWN">The url you are trying to reach appears to be incorrect.</entry>
     <entry key="ELAPSED">Elapsed</entry>
     <entry key="CURRENT_FAILURES_BY_PIPELINE_HISTORY">Current Failures by Pipeline History</entry>
     <entry key="TOTAL:">Total:</entry>
diff --git a/server/webapp/localize_ja.xml b/server/webapp/localize_ja.xml
@@ -116,7 +116,7 @@
     <entry key="FAILED_JOBS">Failed: {0}</entry>
     <entry key="IN_PROGRESS_JOBS">In Progress: {0}</entry>
     <entry key="UNABLE_TO_RETRIEVE_FAILURE_RESULTS">Unable to retrieve failure results.</entry>
-    <entry key="URL_NOT_KNOWN">The url [ {0} ] you are trying to reach doesn''t appear to be correct.</entry>
+    <entry key="URL_NOT_KNOWN">The url you are trying to reach appears to be incorrect.</entry>
     <entry key="ELAPSED">Elapsed</entry>
     <entry key="CURRENT_FAILURES_BY_PIPELINE_HISTORY">Current Failures by Pipeline History</entry>
     <entry key="TOTAL:">Total:</entry>

Original file line number	Diff line number	Diff line change
`@@ -92,8 +92,8 @@ public static Localizable X_of_Y(Object x, Object y) {`
`92`	`92`	`return new LocalizedKeyValueMessage(LocalizedKeyValueMessage.X_OF_Y, x, y);`
`93`	`93`	`}`
`94`	`94`
`95`		`- public static Localizable urlNotKnown(String url) {`
`96`		`- return new LocalizedKeyValueMessage(LocalizedKeyValueMessage.URL_NOT_KNOWN, url);`
	`95`	`+ public static Localizable urlNotKnown() {`
	`96`	`+ return new LocalizedKeyValueMessage(LocalizedKeyValueMessage.URL_NOT_KNOWN);`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`public static Localizable stageNotFound(StageIdentifier stageLocator) {`