Show server side timer validation on config SPA. (#2703)

varshavaradarajan · zabil · commit 761b41172284 · 2016-10-04T17:08:58.000+05:30
diff --git a/server/webapp/WEB-INF/rails.new/app/assets/new_javascripts/models/pipeline_configs/pipeline.js b/server/webapp/WEB-INF/rails.new/app/assets/new_javascripts/models/pipeline_configs/pipeline.js
@@ -98,6 +98,7 @@ define(['mithril', 'lodash', 'string-plus', 'models/model_mixins', 'models/pipel
   Pipeline.Timer = function (data) {
     this.constructor.modelType = 'pipelineTimer';
     Mixins.HasUUID.call(this);
+    Validatable.call(this, data);
 
     this.spec          = m.prop(s.defaultToIfBlank(data.spec, ''));
     this.onlyOnChanges = m.prop(data.onlyOnChanges);
@@ -110,8 +111,9 @@ define(['mithril', 'lodash', 'string-plus', 'models/model_mixins', 'models/pipel
   Pipeline.Timer.fromJSON = function (data) {
     if (!_.isEmpty(data)) {
       return new Pipeline.Timer({
-        spec:          data.spec,
-        onlyOnChanges: data.only_on_changes
+        spec:                  data.spec,
+        onlyOnChanges:         data.only_on_changes,
+        errors:                data.errors
       });
     }
   };
diff --git a/server/webapp/WEB-INF/rails.new/app/assets/new_javascripts/views/pipeline_configs/pipeline_settings_widget.js.msx b/server/webapp/WEB-INF/rails.new/app/assets/new_javascripts/views/pipeline_configs/pipeline_settings_widget.js.msx
@@ -62,7 +62,7 @@ define([
               <f.inputWithLabel model={pipeline.timer()}
                                 attrName='spec'
                                 label='Cron timer specification'
-                                validate={false}
+                                validate={true}
                                 tooltip={{
                                   content: <tt.pipeline.timer.spec callback={pipeline.timer().spec}/>,
                                   direction: 'bottom',
