fix: fixed a problem that MarshalIndent does not work when UnorderedMap is specified#435
Merged
goccy merged 2 commits intogoccy:masterfrom Mar 13, 2023
Merged
fix: fixed a problem that MarshalIndent does not work when UnorderedMap is specified#435goccy merged 2 commits intogoccy:masterfrom
goccy merged 2 commits intogoccy:masterfrom
Conversation
…ap is specified fixed negative overflow on appendObjectEnd fixed output on appendColon and appendObjectEnd fix goccy#417
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #435 +/- ##
==========================================
+ Coverage 76.95% 77.10% +0.14%
==========================================
Files 55 55
Lines 18820 18821 +1
==========================================
+ Hits 14483 14511 +28
+ Misses 3698 3676 -22
+ Partials 639 634 -5 |
Owner
|
LGTM Ah, maybe we have never tested the combination of unordered map and indent before ? |
Contributor
Author
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed negative overflow on appendObjectEnd
fixed output on appendColon and appendObjectEnd
fix #417