fix: In decodeUnicode, the case that the expected buffer's state is not satisfied after reading.#380
Merged
goccy merged 2 commits intogoccy:masterfrom Jul 9, 2022
Merged
Conversation
…ot satisfied after reading. fix goccy#374
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
==========================================
+ Coverage 79.94% 79.95% +0.01%
==========================================
Files 52 52
Lines 17578 17582 +4
==========================================
+ Hits 14053 14058 +5
+ Misses 2957 2955 -2
- Partials 568 569 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #374
io.MultiReaderなどを使うケースでReadをしてもio.EOFでなく要求したバイト数取得できないケースが存在する.
その際にfilledBufferがfalseになる. filledBufferがfalseの場合, bufferを拡張する処理が動かないため再利用の処理のみが実行される.
decodeUnicodeRuneの内部においてbufferが拡張される前提で書かれている処理があり, それが原因でpanicが発生していた.
新たに readAtLeast という関数を導入し, 期待するバッファーの状態を満たすようにした.