Setup multi-arch builds for Docker.#401
Conversation
|
@goccy sorry to bother you but this has been sitting for 9 months - mind letting me know if there's anything I can do to improve it? |
| ARG DEBIAN_VERSION=bookworm | ||
|
|
||
| ARG VERSION | ||
| FROM golang:${DEBIAN_VERSION} AS cgo_builder |
There was a problem hiding this comment.
I'm concerned that by not using the zetasqlite image, the build cache won't be effective. Also, for maintenance purposes, the build command needs to be consolidated into the Makefile.
There was a problem hiding this comment.
While that's totally fair, I think this is still better for a couple of reasons!
- That container is not multi-arch.
- The build done by referencing the library in another image will not be reproducible, and will be subject to skew from what zetasql version the other image happened to be at the time.
- There is not much to cache anyways, as the build is pretty quick (a couple of minutes on my machine). If you want, I can follow this up with a CI/CD PR to automatically build the docker containers on release.
There was a problem hiding this comment.
oh wait you already have the docker CI/CD built to run on release, the one I modified.
There was a problem hiding this comment.
Also, the docker build step is already in the Makefile, that has not changed!
A static build is not yet possible in ARM64.
4940e36 to
2ae6dba
Compare
|
Hi @goccy just bumping this again! This will make it much easier to use this on non-x84 systems! |
|
Thank you for your contribution ! LGTM 👍 |
|
Thank you so much @goccy for accepting my change and maintaining this package! |
|
Great to see this land! I believe a new release is still needed before the new arm64 build is available, correct? |
A static build is not yet possible in ARM64.