Added expose 9050, 9060 on Dockerfile#146
Closed
mbobrovskyi wants to merge 2 commits into
Closed
Conversation
Owner
|
Thank you for your contribution. The default ports for bigquery-emulator are indeed 9050,9060, but they are not fixed. It can be started on any port by the user. So I don't think it's appropriate to explicitly put the port number in the Dockerfile. |
|
Gitlab uses the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have added expose ports in Dockerfile. Because dktest (https://github.com/dhui/dktest) can't find this ports by default. I would be grateful if you accept this PR and rebuild Docker image.