fixed incorrect titleizing of unicode string#68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is being done in this PR?
Titleize()of Unicode stringHumanize()which is now depends onTitleize()fixes #67
What are the main choices made to get to this solution?
The previous code uses
rune(part[0])to pick the first character of the string but this is incorrect usage of the rune type. It should be[]rune(part)[0]. We can also consider usinggolang.org/x/textmodule to handle this issue better in the future.What was discovered while working on it? (Optional)
Titleize()ignores a part that starts with a special character such as`,*so the result will be:runecorrectly" --> "UsingruneCorrectly" (which is fine)We need to reconsider the design.