fixed #24 by adjusting the function's conditions#60
Merged
Conversation
sio4
commented
Sep 3, 2022
This was referenced Sep 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function logic has inconsistent condition logic even though the purpose of the function should be to remove special characters from the given string to make it suitable as a general folder name.
Simplified the condition and processing flow and the issue was fixed. now, the transformation is simple, all of the following will be
admin_user:AdminUseradminUseradmin-useradmin_useradmin^userThis is a breaking change to the users who used the pascal case names as the argument of the function since those were transformed into a sub-folder form previously.
fixes #24 and maybe gobuffalo/buffalo#1769 too.