Remove oot/eet from suffix rules#54
Merged
Merged
Conversation
Contributor
Author
|
Hi @sio4, do you have a rough eta for a new release with the latest changes? |
Member
|
@paganotoni Could you please take a look at this? I've recently merged some pending PRs and I think we can release a new version with it. |
Member
|
Hi @brycahta , now we have the new version v0.2.5. Thanks @paganotoni ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #53
Description: Removing
{"oot", "eet"},entry from suffix rules because it is causing issues for words likefleet, and I don't think it's popular enough to warrant its own rule/suffix (note: I'm not an english major). For the few exceptions, we can add tosingleToPluralcollection like with tooth/teeth & foot/feetValidation:
make test