flect#47 - Add new rules at the beginning of rules array#48
Merged
Conversation
…rules will be applied first reverse init for to standard rules
650e9ec to
8573c32
Compare
dosco
approved these changes
Sep 1, 2020
dosco
left a comment
There was a problem hiding this comment.
Inserting new rules to the top of the list I feel is the correct way to handle adding to the list as gives users of the library the ability to over-rule existing entries when needed.
Member
|
@renathoaz could you add some tests that specify this ? maybe adding conflicting rules and ensuring that the one added by the user is the one used. |
Member
|
BTW: Thanks for putting this one together I think it makes all the sense. Appreciate it. |
|
Would love to see this merged, it's difficult to replace markbates/inflect with this package without that change. /ping @paganotoni |
Member
|
@paganotoni can we merge this? As you mentioned, this PR is reasonable and will work fine. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So when call Pluralize or Singularize, the new rules will be executed instead of the standard rules.