better handling of multi-word idents#29
Merged
Merged
Conversation
ghost
reviewed
Nov 21, 2019
ghost
left a comment
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
Contributor
Author
|
Another possible approach to this would be to just treat everything as a suffix rule instead of using the map of complete words. I'm happy to change this if that seems like a better approach. |
Replace only the last part of an ident when pluralizing
3cba054 to
a7e5361
Compare
Contributor
Author
|
hmm, I realized I probably need to make similar changes to singularize.go |
paganotoni
approved these changes
Aug 27, 2020
Member
|
Thanks @pgier ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tablize_test includes some examples of multi-word idents. In these situations, it seems better to pluralize only the last word vs. treating the whole phrase as a single word.