Conversation
michael-schwarz
approved these changes
Feb 19, 2023
sim642
requested changes
Feb 20, 2023
Member
sim642
left a comment
There was a problem hiding this comment.
Once goblint/gobview#19 is merged, this also needs to update the git submodule.
Co-authored-by: Simmo Saan <simmo.saan@gmail.com>
sim642
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes that were made on the Goblint side to fix issue goblint/gobview#2 and the timing statistics displayed in Gobview:
When Goblint is run with gobview enabled, all C source files (from warning locations) will be copied to the directory served by Gobview. The files receive a unique name to avoid any clashes between files from different directories. The mapping from the filename used in CIL-locations to this unique file name is marshalled additionally such that it can be accessed by Gobview. This way, the files can be displayed in Gobview without accessing any other parts of the filesystem. I tested this fix for C files located within the Goblint directory as well as for files outside. However, I am assuming, that one might need to extend this solution for it to work with the compilation database setup as well.
Furthermore, this PR fixes the timing statistics displayed in Gobview. Instead of marshaling incomplete timings within analyze, where the overall analysis time has not been calculated yet, they are now only marshaled after finishing the analysis.
TODO