Conversation
1 task
sim642
reviewed
Oct 21, 2022
Member
sim642
left a comment
There was a problem hiding this comment.
I think 14-mutex-simple-wrap2 should also have incr extraced and still work with 2 fuel. All three programs and patches are supposed to be identical, just with different fuel options.
michael-schwarz
approved these changes
Oct 24, 2022
sim642
approved these changes
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to remove the respective dependencies/influences of an unknown from
side_dep,side_inflandinflbefore (instead of in between the recursive calls) ofdestabilize_with_sides. It would make sure that the same unknown isalways destabilized with the same fuel.
If not, the behavior of restart with fuel is a little unexpected. The fuel could possibly be reduced during the destabilization of
side_depentries and then be less then before when getting back and destabilizing the initial unknown based on entries ininfl. This can also leads to a different result when using the CFG comparison. It can be observed in11-restart/15-mutex-simple-wrap1.c:Since the function wrap is changed and destabilized, one would suspect that 1 fuel is sufficient to restart
myglobal(with write-only restarting disabled). Instead the fuel is lost when destabilizing throughside_depinmainfirst and is only 0 when wrap is finally destabilized based oninfl. So the race warning is not removed. With the CFG comparison on the other hand, the destabilization immediately starts with the entries ininfl(because there are none inside_dep), restartsmyglobalbecause fuel is still 1 and successfully removes the race warning.I also changed the test case to make them more meaningful with respect to the changes in this PR. It would also fix the open todo in #841.