Remove erroneous call to truncateCilint in min_for#782
Merged
michael-schwarz merged 5 commits intomasterfrom Jul 13, 2022
Merged
Remove erroneous call to truncateCilint in min_for#782michael-schwarz merged 5 commits intomasterfrom
truncateCilint in min_for#782michael-schwarz merged 5 commits intomasterfrom
Conversation
jerhard
reviewed
Jul 13, 2022
jerhard
reviewed
Jul 13, 2022
Co-authored-by: Julian Erhard <julian.erhard@yahoo.de>
jerhard
approved these changes
Jul 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
truncateCilintinmin_forhides overflows that might happen, so it is incorrect to call it here.Closes #769