Pass Escaped Locals to Callee as They Need to Be Considered Globals#779
Merged
michael-schwarz merged 5 commits intomasterfrom Jul 12, 2022
Merged
Pass Escaped Locals to Callee as They Need to Be Considered Globals#779michael-schwarz merged 5 commits intomasterfrom
michael-schwarz merged 5 commits intomasterfrom
Conversation
sim642
approved these changes
Jul 12, 2022
Member
sim642
left a comment
There was a problem hiding this comment.
Good catch! I had forgotten that the escaping into globals applies to singlethreaded mode as well. Although the module name is still ThreadEscape and its top comment also just mentions escaping to threads. Maybe we should bring that up to date.
sim642
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, escaped locals (pointer was saved into globals) are not correctly passed to callees, as
enterfilters viaBasetype.Variables.is_global kinstead ofis_global (Analyses.ask_of_ctx ctx) k.Looking up the corresponding value in the local state then leads to
bot, which is ignored when merging over all possible addresses that a pointer may point to.Minimal example:
TODO: Investigate if this fixes the unsoundnesses for SV-Comp.