Interactive: improvements for smtprc story#729
Merged
sim642 merged 6 commits intointeractivefrom May 19, 2022
Merged
Conversation
Member
Author
|
This should allow the story for smtprc to proceed. I will check if I can replicate the chrony story with this merged into the chrony branch. |
Member
Author
|
I can replicate the chrony story with these changes, so I think we should merge. |
michael-schwarz
approved these changes
May 6, 2022
Member
|
This is currently on top of #724, so merging this would just add to that PR, possibly confusing things. |
sim642
approved these changes
May 6, 2022
Member
Author
|
Yeah, that's true... I don't even know why I spoke of merging in order to test this. Let's wait until next week with all the mergers then. We can just package this and the bigger-benchmark branches. We should even keep those names since they are so informative. :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating this to get some help. I'll try to create some eleventh hour workaround, and then maybe we can fix this for real.
strncator something and realized thatstrcatis already there but different fromstrcpy. I think the first argument is the destination for both, but it might be worth checking this because it is wrong in master as well.