Conversation
sim642
requested changes
Feb 4, 2022
sim642
reviewed
Feb 8, 2022
93939a5 to
384b25c
Compare
Member
|
I fixed the merge conflict myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes
cilly make-ooption was not included in the arguments explicitly and so the preprocessing in Goblint failed. Since the generated compilation database generally looked fine to me and I couldn't find anything about the option-obeing a required option in the arguments, I decided to extend the preprocessing in Goblint to handle this case.