Skip to content

Fix int domain test failures#579

Merged
sim642 merged 11 commits intomasterfrom
issue-575
Feb 3, 2022
Merged

Fix int domain test failures#579
sim642 merged 11 commits intomasterfrom
issue-575

Conversation

@sim642
Copy link
Copy Markdown
Member

@sim642 sim642 commented Jan 28, 2022

Closes #575.

@sim642 sim642 self-assigned this Jan 28, 2022
@sim642 sim642 marked this pull request as ready for review January 31, 2022 08:59
@michael-schwarz
Copy link
Copy Markdown
Member

Related: #99

@sim642 sim642 linked an issue Jan 31, 2022 that may be closed by this pull request
@sim642 sim642 merged commit efcc468 into master Feb 3, 2022
@sim642 sim642 deleted the issue-575 branch February 3, 2022 09:10
@michael-schwarz
Copy link
Copy Markdown
Member

This breaks on OCaml < 4.13 since Int.max and Int.min were only introduced in that version.

@sim642
Copy link
Copy Markdown
Member Author

sim642 commented Feb 3, 2022

Ugh, ok. That's what we get for disabling the complete unlocked workflor for PRs. I'll fix it on master.

@sim642 sim642 added this to the v2.0.0 milestone Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Int domain failures with many ikinds Fix and uncomment failing domain property tests

2 participants