Conversation
All solvers are eq solvers already.
This will be needed for side_infl collecting inside incremental TD3.
Now save_run is a postsolver, which outputs eq hashtable, and load_run is a solver, which inputs eq hashtable. By being a solver, all the standard postsolvers can be applied, including warn.
Turns out modifying Hashtbl during iteration is problematic in practice.
This is undefined behavior.
jerhard
reviewed
Oct 5, 2021
This was referenced Oct 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #367, among other things.
Changes
Verify2checkedGlobConstrSys, but in the combined mechanism it checksEqConstrSys.Hashmodule.Hashtblduring iteration, which according to documentation is undefined behavior. Also add a Semgrep rule to detect such code. This was actually a problem when I tried the same in the newload_runimplementation.TODO
Check if
load_runstill works (outputs warnings).save_runis now also a postsolver, which marshals the solution toEqConstrSys(notGlobConstrSys), andload_runis a special solver, which just unmarshals the solution. The latter will then run standard postsolvers, including warn to get warnings.Adapt
compare_runsto changed run marshaling.Instead of rewriting
CompareforEqConstrSys, I just split their unmarshaled solutions intoGlobConstrSyssolutions.