Merged
Conversation
…remental analysis
The previous implementation with List.assoc_opt used the polymorphic compare, which might lead to out of memory exceptions when used with unmarshalled objects
sim642
requested changes
Sep 22, 2021
Member
sim642
left a comment
There was a problem hiding this comment.
If malloc varinfo names need to be changed from locations to IDs, then shouldn't the same be done to thread ID varinfo names? And potentially some other uses as well?
I'm wondering though, how we could make it as user-friendly as before, because now it's very difficult to inspect the analysis results and know where a particular allocation is from. You'd have to click through all function CFGs to find the one which contains the ID in the varinfo.
sim642
requested changes
Sep 24, 2021
sim642
reviewed
Sep 27, 2021
sim642
reviewed
Sep 27, 2021
sim642
approved these changes
Sep 29, 2021
This was referenced Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains some general updates for the incremental analysis. Its part of #351, the two improvements build upon this updated version of the incremental analysis. This PR contains: