You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I thought we could drop the ocaml-monadic dependency since OCaml introduced definable binding operators in 4.08.0.
However, not having something like ;%bind makes the code a bit ugly to read.
I only changed pml_arinc.ml which compiles - pml_osek.ml is the same.
I merged master into this now such that we can decide to merge or close. I personally don't have strong feelings either way, but I think it is a good idea to reduce the number of old open PRs and issues.
I only changed pml_arinc.ml which compiles - pml_osek.ml is the same.
Ah, I guess after #735 that doesn't need to be done.
I would be for doing this change since the slight extra ugliness is just in one obscure module and let* () = isn't much more code than ;bind, but it is more standard now, especially since we use let* in some other places as well.
The ocaml-monadic dependency could now be dropped from dune-project, etc entirely though.
Actually, the ;bind/let* () could maybe be replaced with an appropriate infix operator definition for >> (i.e. a version of monadic bind that ignores the first value). Although Pml uses some other weird definition of >>, which is completely unrelated, so it's probably easiest to skip this and stay with the changes already made in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought we could drop the ocaml-monadic dependency since OCaml introduced definable binding operators in 4.08.0.
However, not having something like
;%bindmakes the code a bit ugly to read.I only changed
pml_arinc.mlwhich compiles -pml_osek.mlis the same.We can close this if there's no better solution.