Conversation
…e precise than old and mine
This breaks 13/19 and 28/10.
Previously sigint just printed solver stats and left running.
Reflects the fact that side effecting of global inits is disabled better.
Member
|
In general, I'm very surprised by how modular the different privatisations turned out, that is a very nice touch! |
Doesn't make sense for new privatizations, moved into old privatizations.
Member
|
Sorry, about the mess, I clicked on |
Member
|
Is there still anything blocking us from merging? |
Member
Author
|
Not from my side, so I suppose I'll do the merge? Since nobody else would probably try or review this branch anyway, we won't find out about possible regressions until it's on |
This was referenced Apr 27, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening this humongous draft pull request already now to have a place for keeping some notes on all the changes
tracesbranch contains, including many general improvements etc.Eventually these would get merged into
master.Overview of changes
exp.privatizationoption.protection-readakaProtectionBasedPrivwith additional readable lockset check aka Protection-Based Reading with additional readable lockset check. The additional check is necessary to handle many of our regression tests.// TODOcomments to be useful with regression testing script.base.mltobasePriv.ml.baseanalysis local domain has third privatization-dependent component (by @vesalvojdani).baseanalysis global domain is privatization-dependent.reasonargument tosynctransfer function to allow analyses choose if they want to do computations at every node, or only at some necessary places (like join).mutexanalysis.mutexanalysis (by @vesalvojdani).ctx.emitandeventtransfer function) for deduplicating thread creation, lock, unlock and escape logic in different analyses.MCPSpecfor analyses insideMCP.ctx.split's explicit branch arguments with arbitrary events.privPrecCompare.read_globalresults viaexp.priv-prec-dumpoption.exp.earlyglobsalready during global initialization.Controlearlier to allowenter_withandotherstateto alsosideg(issue Move extern inits, global inits and otherfuns spawning into constraint system #178).sem(semantics) category of options for configuring what unknown functions etc may and may not do.Deadcodebehavior ofinvarianton binary operators.AfterConfigmodule for running initialization things after config has been loaded.RichVarinfomodule for abusingvarinfos to represent richer data, particularly as global constraint variables.Things broken
protection-vesalfor them now, butoldpasses as well.MapDomaininterface changes from Optimize large CPAs #164. Domain tests fail forHoareMap.